minder icon indicating copy to clipboard operation
minder copied to clipboard

Pass in the providerID to DeleteEntityByName

Open jhrozek opened this issue 1 year ago • 1 comments

we're calling DeleteEntityByName to get rid of closed PRs. At that point we have the providerID but we're not passing it to the DB Delete function.

jhrozek avatar Sep 10 '24 07:09 jhrozek

Scenario:

You might have the same name in two different providers, so we should require the provider information when deleting by name. e.g. if you have a mindersec in a gitlab provider and also in a github provider, deleting ("mindersec") might do an unintended delete.

evankanderson avatar Jan 14 '25 14:01 evankanderson