minder
minder copied to clipboard
Two fixes for GetEntityByName
Summary
- Add the sqlc-generating comment to GetEntityByName - We forgot the comment that makes sqlc generate the code.
- Do not lowercase when searching an entity by name - I don't think lowercasing is the responsibility of the database layer, it should be the provider who should return the entity information lowercased through the naming interface.
Change Type
- [x] Bug fix (resolves an issue without affecting existing features)
- [ ] Feature (adds new functionality without breaking changes)
- [ ] Breaking change (may impact existing functionalities or require documentation updates)
- [ ] Documentation (updates or additions to documentation)
- [ ] Refactoring or test improvements (no bug fixes or new functionality)
Testing
in follow up code, right now the code is unused
Review Checklist:
- [x] Reviewed my own code for quality and clarity.
- [ ] Added comments to complex or tricky code sections.
- [ ] Updated any affected documentation.
- [ ] Included tests that validate the fix or feature.
- [ ] Checked that related changes are merged.
@jhrozek - it seems there are some linting issues 👍
Looks like you need to re-run make gen to recreate the DB mocks.