minder icon indicating copy to clipboard operation
minder copied to clipboard

EntityInfoWrapper.GetEntityDBIDs() hardcodes an architecture limitation

Open puerco opened this issue 1 year ago • 2 comments

The EntityInfoWrapper.GetEntityDBIDs() function returns UUIDs for three specific entity types: repo, artifact, and pull request:

https://github.com/stacklok/minder/blob/e77e1427679fc3b18111cfc565559dc661ab789f/internal/engine/entities/entity_event.go#L252-L255

To expand Minder in the future to handle other entity types we should replace this function and all its invocations with a more flexible alternative to work with any future entity.

puerco avatar Jul 11 '24 02:07 puerco

@JAORMX -- do you want to "adopt" this as part of your entity rework?

evankanderson avatar Sep 10 '24 14:09 evankanderson

Oh, this is accidentally being addressed. Yeah, assign it to me. Hopefully by the end of the week this will no longer be an issue.

JAORMX avatar Sep 10 '24 15:09 JAORMX

this has been addressed and this function is no longer part of Minder.

JAORMX avatar Nov 14 '24 09:11 JAORMX