minder icon indicating copy to clipboard operation
minder copied to clipboard

Connect reminder service to minder server to dispatch reminders

Open Vyom-Yadav opened this issue 1 year ago • 6 comments

Summary

Provide a brief overview of the changes and the issue being addressed. Explain the rationale and any background necessary for understanding the changes. List dependencies required by this change, if any.

Issue #2262 (Task - I)

Adds logic for sending reminders to the minder server. Minder server processes these reminders to trigger a TopicQueueReconcileRepoInit event to reconcile a repository.

Change Type

Mark the type of change your PR introduces:

  • [ ] Bug fix (resolves an issue without affecting existing features)
  • [x] Feature (adds new functionality without breaking changes)
  • [ ] Breaking change (may impact existing functionalities or require documentation updates)
  • [ ] Documentation (updates or additions to documentation)
  • [ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations. Attach screenshots if helpful.

Tested locally (no unit tests)

Review Checklist:

  • [x] Reviewed my own code for quality and clarity.
  • [x] Added comments to complex or tricky code sections.
  • [ ] Updated any affected documentation.
  • [ ] Included tests that validate the fix or feature.
  • [x] Checked that related changes are merged.

cc @evankanderson

Vyom-Yadav avatar Jun 16 '24 16:06 Vyom-Yadav

Coverage Status

coverage: 53.167% (-0.2%) from 53.4% when pulling d480686f9cf4dd49776767faf4a7d4f679a828cb on Vyom-Yadav:send-reminder-events into cd7a0f287107e947cd7088bce8972b5524bea3fb on stacklok:main.

coveralls avatar Jun 16 '24 16:06 coveralls

Coverage Status

coverage: 53.172% (-0.2%) from 53.4% when pulling d480686f9cf4dd49776767faf4a7d4f679a828cb on Vyom-Yadav:send-reminder-events into cd7a0f287107e947cd7088bce8972b5524bea3fb on stacklok:main.

coveralls avatar Jun 16 '24 16:06 coveralls

Coverage Status

coverage: 53.177% (-0.2%) from 53.4% when pulling d480686f9cf4dd49776767faf4a7d4f679a828cb on Vyom-Yadav:send-reminder-events into cd7a0f287107e947cd7088bce8972b5524bea3fb on stacklok:main.

coveralls avatar Jun 16 '24 16:06 coveralls

Coverage Status

coverage: 53.818% (-0.2%) from 53.979% when pulling f4968bd06322aa2a44ff7e5b201d03c9db5662c4 on Vyom-Yadav:send-reminder-events into e10dba16f9f3079d040a2a183b6497f7a0921d0e on stacklok:main.

coveralls avatar Jul 20 '24 10:07 coveralls

Sorry for the delay on this. Somehow, all weekends got occupied with one thing or the other :)

Vyom-Yadav avatar Jul 20 '24 18:07 Vyom-Yadav

Sorry for the delay on this. Somehow, all weekends got occupied with one thing or the other :)

No problem, I've been in-and-out the last few weeks anyway. I'll try to take a look at this later today or tomorrow.

evankanderson avatar Jul 29 '24 13:07 evankanderson

@evankanderson not found (404), where are you 😆

image

Vyom-Yadav avatar Aug 22 '24 09:08 Vyom-Yadav