minder icon indicating copy to clipboard operation
minder copied to clipboard

Entity info is missing in `ListEvaluationResults` for pull requests and artifacts

Open eleftherias opened this issue 1 year ago • 3 comments

Describe the issue

When calling ListEvaluationResults, the response includes the entityInfo only if the entity type is a repository. This is different than the response from GetProfileStatusByName, which includes the entityInfo for all types, including pull requests and artifacts.

We should update ListEvaluationResults to return entityInfo for all entities. Ideally we should reuse the code across both functions. Additionally, consider whether entityInfo should be a struct, instead of a simple map.

To Reproduce

No response

What version are you using?

No response

eleftherias avatar Apr 16 '24 16:04 eleftherias

note: this needs coordination with the frontend team

eleftherias avatar Apr 18 '24 13:04 eleftherias

I'm not sure if this leads to any quality issues that @ethomson would be interested in.

evankanderson avatar Jul 30 '24 13:07 evankanderson

Alternate suggestion: Return the type and ID of the entity, but do not return additional information. As we add additional providers and entity types, having entity details in this endpoint wont scale.

Another alternative: Return list of properties from central entities table.

dmjb avatar Aug 15 '24 12:08 dmjb