minder icon indicating copy to clipboard operation
minder copied to clipboard

PR "from" branch only uses rule type to generate the name

Open jhrozek opened this issue 2 years ago • 3 comments

Describe the issue

When opening a PR, we need to open a PR from a branch. We derive the name of the branch from the "title" of the PR in the rule type, but that doesn't work well if we have two rules using the same rule type unless there's something temptable in the title. We should take the name of the rule into account as well.

To Reproduce

Create a profile that uses two codeql rules, see them race.

What version are you using?

No response

jhrozek avatar Feb 14 '24 14:02 jhrozek

Needs to be retested

dussab avatar May 28 '24 13:05 dussab

@rdimitrov -- did you fix this in one of your refactors?

evankanderson avatar Aug 27 '24 13:08 evankanderson

@evankanderson - I'll test it 👍

rdimitrov avatar Aug 27 '24 14:08 rdimitrov