minder icon indicating copy to clipboard operation
minder copied to clipboard

Split ProfileService proto to ProfileService and RuleTypeService

Open rdimitrov opened this issue 2 years ago • 3 comments

The ProfileService has RPC methods for both profiles and rule types, so it's nicer if we split it.

Example of the server-side methods:

type ProfileServiceServer interface {
	CreateProfile(context.Context, *CreateProfileRequest) (*CreateProfileResponse, error)
	UpdateProfile(context.Context, *UpdateProfileRequest) (*UpdateProfileResponse, error)
	DeleteProfile(context.Context, *DeleteProfileRequest) (*DeleteProfileResponse, error)
	ListProfiles(context.Context, *ListProfilesRequest) (*ListProfilesResponse, error)
	GetProfileById(context.Context, *GetProfileByIdRequest) (*GetProfileByIdResponse, error)
	GetProfileStatusByName(context.Context, *GetProfileStatusByNameRequest) (*GetProfileStatusByNameResponse, error)
	GetProfileStatusByProject(context.Context, *GetProfileStatusByProjectRequest) (*GetProfileStatusByProjectResponse, error)
	ListRuleTypes(context.Context, *ListRuleTypesRequest) (*ListRuleTypesResponse, error)
	GetRuleTypeByName(context.Context, *GetRuleTypeByNameRequest) (*GetRuleTypeByNameResponse, error)
	GetRuleTypeById(context.Context, *GetRuleTypeByIdRequest) (*GetRuleTypeByIdResponse, error)
	CreateRuleType(context.Context, *CreateRuleTypeRequest) (*CreateRuleTypeResponse, error)
	UpdateRuleType(context.Context, *UpdateRuleTypeRequest) (*UpdateRuleTypeResponse, error)
	DeleteRuleType(context.Context, *DeleteRuleTypeRequest) (*DeleteRuleTypeResponse, error)
	mustEmbedUnimplementedProfileServiceServer()
}

rdimitrov avatar Jan 12 '24 15:01 rdimitrov

Hey @rdimitrov can I work on this issue

Of course! 🚀

rdimitrov avatar Jan 27 '24 19:01 rdimitrov

ok @rdimitrov

nitishmalang avatar Jan 27 '24 19:01 nitishmalang

Unassigning @nitishmalang since they want to work on something else 👍

rdimitrov avatar Jul 15 '24 10:07 rdimitrov