bug: package vulnerability interface should reuse `http.Client`

Open jhrozek opened this issue 2 years ago • 2 comments

At the moment the package vulnerability interface implementation (OSV and soon-to-be-added Pi) instantiate a http.Client on every call. This is wasteful, we should reuse a client to improve performance. We already do this via a simple map for the package database, we should do the same for the vulnerability interface, too.

Oct 15 '23 19:10 jhrozek

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Nov 24 '23 01:11 github-actions[bot]

We should measure whether this is actually a problem in practice.

Jul 10 '24 13:07 evankanderson

This hasn't been hurting us in practice.

Sep 10 '24 13:09 evankanderson