laravel-google-cloud-tasks-queue icon indicating copy to clipboard operation
laravel-google-cloud-tasks-queue copied to clipboard
verified publisher icon stackkit

remove task name

Open tsel-59 opened this issue 1 year ago • 3 comments

tsel-59 avatar Mar 05 '24 18:03 tsel-59

I can't run the tests locally, so this will have test failures

tsel-59 avatar Mar 05 '24 18:03 tsel-59

A pre-defined task name was heavily used and expected in some places in the package. Removing it caused too much things to break, sadly! Apologies, my suggestion was too vigorous 😛. Therefore, as a compromise, I've changed it to using a hashed value for the task ID. What do you think?

marickvantuil avatar Mar 06 '24 21:03 marickvantuil

it would be helpful to make the suffix the $displayName so that we can still search by job in the the GCP dashboard. Seems like google just wants the prefix of the job to be a randomized hash.

tsel-59 avatar Mar 07 '24 16:03 tsel-59

Hey, I'm going to close this PR - v4 of the package will prefix the task name with a random hash

marickvantuil avatar May 26 '24 16:05 marickvantuil