Improved navigation with dedicated mobile navigation
I'll write up more about this tomorrow if I'm short here, but the overarching thing is redone navigation to make room for a multi-select for territory filtering.
Extras:
- dedicated mobile navigation (eg bottom navbar, offcanvas)
- sticky minimal navigation bar so you navigate easily when you're deep in comment threads
- search defaults to searching all territories
- more intuitive search filters
- when you're logged out, you're visually "logged in" as anon
- 404's redirect to /404 (vs rewrite) to fix CSP issues
- redone copy on login/signup pages
Summary by CodeRabbit
-
New Features
- Added territory filtering to search queries.
- Introduced new navigation components and layouts for desktop and mobile views.
- Implemented off-canvas navigation for mobile.
- Added functionality for managing notifications related to new notes.
- Updated filter descriptions on the search page for clarity and organization.
-
Bug Fixes
- Fixed a redirection issue for not found scenarios, now redirects to
/404.
- Fixed a redirection issue for not found scenarios, now redirects to
-
Style
- Updated various components with new class names and styles for improved visual appearance and responsiveness.
- Introduced new CSS classes and adjusted existing ones across multiple components.
-
Refactor
- Simplified conditional rendering logic in components.
- Adjusted class names and layout structures in layout components.
- Removed unused styles and properties.
-
Chores
- Updated text content and styling in login and signup pages for a better user experience.
- Removed the
WelcomeBannercomponent from the homepage.
-
Documentation
- Removed
rel='preload'attribute from font links for optimization.
- Removed
Walkthrough
The update introduces a range of modifications across the application, focusing on enhancing navigation, refining UI components, and improving user experience. Key changes include the addition of territory filtering in search, redirection adjustments for better user flow, UI updates in components for consistency and responsiveness, and the introduction of new navigation structures for both desktop and mobile. The update aims to make the application more intuitive and visually appealing, while also streamlining user interactions.
Changes
| Files | Change Summaries |
|---|---|
api/resolvers/search.jsapi/ssrApollo.js |
Added territory parameter for filtering; modified redirection logic. |
components/.../fee-button.jscomponents/.../hat.jscomponents/.../hidden-wallet-summary.jscomponents/.../post.jscomponents/.../sub-select.js |
Updated UI elements for consistency; adjusted class names and properties. |
components/.../*.module.cssstyles/... |
Removed specific styling; added new styles for responsiveness and alignment. |
components/layout.jscomponents/layout.module.css |
Renamed and updated components for navigation; adjusted layout styling. |
components/nav/... |
Introduced new navigation components for desktop and mobile; refined navigation functionality. |
middleware.jsnext.config.jspages/invites/[id].js |
Updated CSP headers; modified route handling and redirection logic. |
pages/[name]/index.jspages/_app.jspages/_document.jspages/items/[id]/edit.jspages/login.jspages/search.jspages/signup.js |
Enhanced user experience through UI and text content updates; added provider components. |
🐰✨
In the code's quiet burrow, changes abound,
Where navigation flows, and UI's refined.
Through fields of code, our efforts compound,
Enhancing paths that users find.
In every line, a purpose found, a vision twined.
🌟🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>. -
Generate unit-tests for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit tests for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table. -
@coderabbitai show all the console.log statements in this repository. -
@coderabbitai read src/utils.ts and generate unit tests. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - The JSON schema for the configuration file is available here.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json
CodeRabbit Discord Community
Join our Discord Community to get help, request features, and share feedback.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/[email protected] | None | 0 |
23.6 kB | jedwatson |
- Header is not always immediately sticky, not sure if on purpose
Occasionally the sticky content is not the same as the top navbar, so I unhide the sticky at an offset until you've scrolled beyond the navbar. There's definitely room for improvement there.
In general, not sure how I feel about the different layouts which lead to different experiences on desktop vs mobile.
I agree. I think our next iteration we'll make mobile and desktop more consistent by placing the things that appear in the bottom navbar of mobile, in a left-hand navbar on desktop like Twitter does:
This was already the case but it became more obvious now: The filter(s) in /recent and /top are not aligned. There is some unnecessary top-margin for the top-filters:
Nice catch. I'll take a look at this.