sheetify icon indicating copy to clipboard operation
sheetify copied to clipboard

idea: plugins?

Open yoshuawuyts opened this issue 8 years ago • 3 comments

I want to write a package to dedupe CSS; all of it. Problem is: we can't access the whole bundle because we stream it out. Should we perhaps introduce a plugin system of the sorts and have a labeled pipeline thing like browserify does? Perhaps only allow access to the final output stream?

cc/ @ahdinosaur @hughsk thoughts on how we can apply transformations to all of the CSS? Thanks!

yoshuawuyts avatar Jan 14 '17 02:01 yoshuawuyts

This was brought up by https://github.com/datproject/datfolder/pull/381, which shows we need to dedupe - best would be to operate on all of the CSS ghmm

yoshuawuyts avatar Jan 14 '17 02:01 yoshuawuyts

the simplest option feels like a "global plugin": a function to create a transform stream that is piped the final output stream, but happy with whatever you think is the best way to support your use case. :cherry_blossom:

ahdinosaur avatar Jan 14 '17 04:01 ahdinosaur

Yeah, think so too - tho in on the other hand Browserify is super mature and their plugin design is well thought out; perhaps we should make the leap and copy it? idk

On Sat, Jan 14, 2017 at 5:11 AM Mikey [email protected] wrote:

the simplest option feels like a "global plugin": a function to create a transform stream that is piped the final output stream, but happy with whatever you think is the best way to support your use case. 🌸

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stackcss/sheetify/issues/115#issuecomment-272600358, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWleh421IPhbWcG2jqxu9e6ndUg_DbRks5rSEsCgaJpZM4LjfNH .

yoshuawuyts avatar Jan 14 '17 16:01 yoshuawuyts