hapistrano icon indicating copy to clipboard operation
hapistrano copied to clipboard

check if the path exists before rollback to a specific release.

Open hughjfchen opened this issue 1 year ago • 3 comments

This PR fix #206

hughjfchen avatar Sep 25 '22 10:09 hughjfchen

Yeah, I'd found that just after submit the PR. The strange thing is I'd already click the sync the fork button on my forked repository and it says my fork is not behind the upstream and no need to update. I'm out of idea why this happens.

hughjfchen avatar Sep 30 '22 01:09 hughjfchen

Hi @hughjfchen I assume github made something unexpected when you hit that sync button. I'd suggest to identify you changes and start from scratch:

git remote add sb-hap [email protected]:stackbuilders/hapistrano.git
git fetch --all
git checkout sb-hap/master -- hapistrano.cabal src/System/Hapistrano.hs
$EDITOR src/System/Hapistrano.hs # Make your changes
git add src/System/Hapistrano.hs
git commit -m "..."
git push

Besides that, could you please add a test for your changes? Thanks in advance!

CristhianMotoche avatar Sep 30 '22 15:09 CristhianMotoche

I've updated my fork from scratch and added a test case for this PR.

hughjfchen avatar Oct 05 '22 02:10 hughjfchen