rules_proto icon indicating copy to clipboard operation
rules_proto copied to clipboard

gazelle <0.35 no longer supported

Open jbedard opened this issue 1 year ago • 2 comments

After https://github.com/stackb/rules_proto/commit/5d1fb6aa7f023e8248ed112c269114fa03ae5b94

Was this breaking change intentional with 3.2.0?

I'm unable to upgrade gazelle atm due to https://github.com/bazelbuild/bazel-gazelle/issues/1751 so also can't upgrade rules_proto...

jbedard avatar Mar 07 '24 23:03 jbedard

Yes, this was mentioned in https://github.com/stackb/rules_proto/pull/357 and why I bumped the major version from v2 to v3

pcj avatar Mar 10 '24 06:03 pcj

Perhaps the rules_python gazelle extension is performing resolve in parallel? Maybe that new resolve map in bazel_gazelle needs an RWLock

pcj avatar Mar 10 '24 06:03 pcj