stack icon indicating copy to clipboard operation
stack copied to clipboard

Now allows user to update primary_email_auth_enabled to false via API

Open madster456 opened this issue 6 months ago • 2 comments


[!IMPORTANT] Allows primary_email_auth_enabled to be set to false via API without requiring primary_email.

  • Behavior:
    • Allows primary_email_auth_enabled to be set to false without requiring primary_email in crud.tsx.
    • Updates usedForAuth field in contactChannel when primary_email_auth_enabled is updated without changing primary_email.
  • Code Changes:
    • Replaces || with ?? for primary_email_auth_enabled assignment in crud.tsx.
    • Adds logic to update usedForAuth in contactChannel if primary_email_auth_enabled is updated alone.

This description was created by Ellipsis for 076bb0c9a5374f4e318239ccd6acb2f8242345cc. You can customize this summary. It will automatically update as commits are pushed.

madster456 avatar May 23 '25 21:05 madster456

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 8:27pm
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 8:27pm
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 8:27pm

vercel[bot] avatar May 23 '25 21:05 vercel[bot]

✨ No issues found! Your code is sparkling clean! ✨

🗒️ View all ignored comments in this repo
  • The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
  • Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
  • There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
  • Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

  • Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
  • The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

  • Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
  • The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

  • 'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

  • When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

recurseml[bot] avatar May 23 '25 21:05 recurseml[bot]

Looks great, can you add a few tests to test for this case?

Sure can!

madster456 avatar May 26 '25 19:05 madster456