qgis-stac-plugin
qgis-stac-plugin copied to clipboard
Support for GDAL related assets
This PR implements #217
It provides support for loading assets from GDAL Virtual File Systems keys.
Hi @Samweli I have uploaded more changes. I have noticed that original asset.href attribute is changed when the plugin wants to load the asset. if the authentication expires in a short time next invocations to load the asset again will fail.
Hi @Samweli do you need more info about last changes? Can I help with anything to get this PR merged? Thanks!!
Any feedback @Samweli how to proceed ?
Any feedback @Samweli how to proceed ?
@luipir I ll take a look at the new changes and get back to you guys later, Apologies for a slow reply, We currently don't have enough time to work on support and maintenance.
Any feedback @Samweli how to proceed ?
@luipir @ahuarte47 I have added new comments on the review suggestions, In general I like these new changes to be implemented in a separate function, as I have plans to update the sign_asset_href in the future.
@Samweli reasonable your proposed changes if you are planning to move the code to be more agnostic an not only PC oriented :)
@Samweli reasonable your proposed changes if you are planning to move the code to be more agnostic an not only PC oriented :)
yes @luipir in the future we ll have a sign_asset_href that will support all the url sign based operations.
please @Samweli give us a feedback regarding latest modification done by @ahuarte47, thank you
Just gave a try with private S3 endpoint: it is working great.
The only cumbersome thing is to define the AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_S3_ENDPOINT environment variables
Just saw that GDAL GetSignedURL() returns an URL valid only for 1 hour (however that is not related to this PR)
Any updates on when this PR will be merged?