qgis-stac-plugin icon indicating copy to clipboard operation
qgis-stac-plugin copied to clipboard

Support for GDAL related assets

Open ahuarte47 opened this issue 3 years ago • 11 comments
trafficstars

This PR implements #217

It provides support for loading assets from GDAL Virtual File Systems keys.

ahuarte47 avatar Sep 21 '22 09:09 ahuarte47

Hi @Samweli I have uploaded more changes. I have noticed that original asset.href attribute is changed when the plugin wants to load the asset. if the authentication expires in a short time next invocations to load the asset again will fail.

ahuarte47 avatar Sep 23 '22 09:09 ahuarte47

Hi @Samweli do you need more info about last changes? Can I help with anything to get this PR merged? Thanks!!

ahuarte47 avatar Sep 26 '22 12:09 ahuarte47

Any feedback @Samweli how to proceed ?

luipir avatar Oct 05 '22 15:10 luipir

Any feedback @Samweli how to proceed ?

@luipir I ll take a look at the new changes and get back to you guys later, Apologies for a slow reply, We currently don't have enough time to work on support and maintenance.

Samweli avatar Oct 05 '22 15:10 Samweli

Any feedback @Samweli how to proceed ?

@luipir @ahuarte47 I have added new comments on the review suggestions, In general I like these new changes to be implemented in a separate function, as I have plans to update the sign_asset_href in the future.

Samweli avatar Oct 12 '22 09:10 Samweli

@Samweli reasonable your proposed changes if you are planning to move the code to be more agnostic an not only PC oriented :)

luipir avatar Oct 12 '22 09:10 luipir

@Samweli reasonable your proposed changes if you are planning to move the code to be more agnostic an not only PC oriented :)

yes @luipir in the future we ll have a sign_asset_href that will support all the url sign based operations.

Samweli avatar Oct 12 '22 09:10 Samweli

please @Samweli give us a feedback regarding latest modification done by @ahuarte47, thank you

luipir avatar Nov 09 '22 21:11 luipir

Just gave a try with private S3 endpoint: it is working great.

The only cumbersome thing is to define the AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_S3_ENDPOINT environment variables

remicres avatar Mar 03 '23 11:03 remicres

Just saw that GDAL GetSignedURL() returns an URL valid only for 1 hour (however that is not related to this PR)

remicres avatar Mar 03 '23 11:03 remicres

Any updates on when this PR will be merged?

slesaad avatar Sep 15 '23 14:09 slesaad