pystac icon indicating copy to clipboard operation
pystac copied to clipboard

Flush out the remainder of test_link.py

Open schwehr opened this issue 5 years ago • 1 comments

Things todo and questions to answer from working on #211

  • ~Does class Link need an __eq__? And the same for many of the other classes. The default behavior isn't very useful~ - Moved to #222
  • test_minimal: Cannot call link.get_href() after set_owner. Got an error
  • test_minimal: Test link.resolve_stac_object()
  • Test get_href when href is absolute and there is an owner
  • Test get_absolute_href when there is an owner
  • Test when resolve_stac_object on link when target is a str.

schwehr avatar Oct 27 '20 17:10 schwehr

Moving this out of the 1.4.0 release since it does not seem critical

duckontheweb avatar Feb 23 '22 16:02 duckontheweb

It is a little hard to map these back to the current state of the tests, but I am fairly confident that all the cases listed in the original description are captured in the tests at this point.

This is probably fine to close.

jsignell avatar Apr 10 '23 20:04 jsignell

Yeah, I think so too. There are some slightly worrying misses in the link.py coverage but I don't think any of the suggested fixes in this issue touch those. Closing as done.

gadomski avatar Apr 11 '23 11:04 gadomski