stability-contracts icon indicating copy to clipboard operation
stability-contracts copied to clipboard

24.05.0-alpha; ERC4626StrategyBase, YearnStrategy, StrategyBase 1.1.0

Open a17 opened this issue 1 year ago • 1 comments

YearnStrategy

  • [ ] integration interfaces
  • [x] constants
  • [x] skeleton
  • [x] universal test
  • [ ] implementation
  • [ ] deploy script

ERC4626StrategyBase

  • [x] skeleton
  • [x] storage
  • [ ] getRevenue
  • [x] _depositAssets
  • [x] _withdrawAssets
  • [x] _claimRevenue

StrategyBase 1.1.0

  • [x] autoCompoundingByUnderlyingProtocol()
  • [x] virtual total()

Factory 1.1.0

  • [x] getDeploymentKey() fix for not farming strategies
  • [x] strategyAvailableInitParams(bytes32 idHash) another strategy init params store, for not farming and complex strategies

a17 avatar Apr 29 '24 10:04 a17

Codecov Report

Attention: Patch coverage is 96.93252% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 94.21%. Comparing base (34868d0) to head (481dc8f).

Files Patch % Lines
src/core/libs/VaultBaseLib.sol 94.28% 0 Missing and 2 partials :warning:
src/core/base/VaultBase.sol 83.33% 0 Missing and 1 partial :warning:
src/strategies/base/ERC4626StrategyBase.sol 98.43% 0 Missing and 1 partial :warning:
src/strategies/base/StrategyBase.sol 92.30% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   93.92%   94.21%   +0.28%     
==========================================
  Files          54       57       +3     
  Lines        4148     4304     +156     
  Branches      462      476      +14     
==========================================
+ Hits         3896     4055     +159     
+ Misses        101       94       -7     
- Partials      151      155       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 29 '24 10:04 codecov[bot]