phpstan-dba icon indicating copy to clipboard operation
phpstan-dba copied to clipboard

Doctrina/dbal 2.x compat

Open staabm opened this issue 3 years ago • 2 comments

See https://github.com/doctrine/dbal/blob/3.3.x/UPGRADE.md#deprecated-fetchmode-and-the-corresponding-methods

for newer 2.x releases some api is the same to 3.x.

its only about the low hanging fruit. I guess we mostly need to check places like https://github.com/staabm/phpstan-dba/blob/4d1c84b2dd4241ab9aee1f8e111a84e9d1df6313/src/Extensions/DoctrineConnectionExecuteQueryDynamicReturnTypeExtension.php#L53

And see whether the checked version also satisfies doctrina dbal 2.x

staabm avatar Jan 25 '22 18:01 staabm

@mitelg in case you are interessted in doctrine/dbal 2.x compat, you might invest some time and adjust the version checks in the doctrine-extensions where dbal 2.x is api compatibel with dbal 3.x

staabm avatar Jan 26 '22 08:01 staabm

I cannot promise anything, but maybe I will find some time :slightly_smiling_face:

mitelg avatar Jan 26 '22 10:01 mitelg