websocket-sharp icon indicating copy to clipboard operation
websocket-sharp copied to clipboard

Make HttpServer more consistent with WebSocketServer

Open Rohansi opened this issue 10 years ago • 4 comments

This makes HttpServer more consistent with WebSocketServer by adding missing constructor overloads and properties.

  • Adds constructor overloads enabling listening on specific IP addresses
  • Adds a constructor to get listen parameters from a URL string
  • Fixes a missing null check for IPAddress parameters in WebSocketServer
  • Fixes an error that prevented HttpServer from sending error messages (HttpConnection.cs)

Rohansi avatar Mar 19 '15 03:03 Rohansi

Hello there, thanks for your pull request.

I plan to merge this manually by inches, adding some changes.

And when i merge your code, i will add a contributor info such as below. Is it okay?

/*
 * Contributors:
 * - Rohan Singh <[email protected]>
 */

sta avatar Apr 02 '15 08:04 sta

Yes, that's fine. Thanks.

Rohansi avatar Apr 02 '15 08:04 Rohansi

Any progress on this?

Rohansi avatar May 24 '15 13:05 Rohansi

Not yet. Hold on please.

sta avatar Jun 07 '15 06:06 sta