setup-maven icon indicating copy to clipboard operation
setup-maven copied to clipboard

not able to find v4.5

Open JinoArch opened this issue 2 years ago • 10 comments

I am facing the following issue while running GitHub Actions.

Prepare all required actions
Getting action download info
Error: Unable to resolve action `stCarolas/[email protected]`, unable to find version `v4.5`

Looks like release name/code needs update ? https://github.com/stCarolas/setup-maven/releases ?

updated snippet as

- name: Set up Maven
      uses: stCarolas/[email protected]
      with:
        maven-version: 3.8.2

as per https://github.com/marketplace/actions/setup-maven?version=v.4.5 May be I have to try 4.4!

JinoArch avatar Oct 25 '22 09:10 JinoArch

The tag name is v.4.5 - dot after v - probably misspell in tag name

slawekjaranowski avatar Oct 25 '22 11:10 slawekjaranowski

The tag name is v.4.5 - dot after v - probably misspell in tag name

Then I think we need update in here too? https://github.com/marketplace/actions/setup-maven?version=v.4.5

 uses: stCarolas/[email protected]

JinoArch avatar Oct 25 '22 14:10 JinoArch

Those of us using codeql are getting warnings with v4.4 (or older) versions of setup-maven (as codeql based builds are now enforcing node-16) And this new not-quite-a-version was a bit of a surprise.

joakime avatar Oct 25 '22 18:10 joakime

Thanks. no more warnings in GHA. Please close this one. :)

JinoArch avatar Oct 25 '22 19:10 JinoArch

I still think this is a valid issue to fix in this repo, as the tag should have been v4.5 and not v.4.5

evie-lau avatar Oct 25 '22 19:10 evie-lau

Yes this was really hard to discover especially since the release isn't titled with the version number either - can an extra tag v4.5 be pushed onto the latest release please?

kherock avatar Oct 27 '22 13:10 kherock

v4.5 pushed https://github.com/stCarolas/setup-maven/releases/tag/v4.5 Should be fine now

stCarolas avatar Oct 31 '22 23:10 stCarolas

How about moving the tag v4 to point to v4.5? I thought this would be the best practice: https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

aabeling avatar Jan 04 '23 06:01 aabeling

How about moving the tag v4 to point to v4.5? I thought this would be the best practice: https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

Definitely surprising that this actions doesn't follow this pattern (yet). So +1 from me!

famod avatar Jan 17 '23 18:01 famod

Btw, I think dependabot also considers v4 to be a floating tag because I haven't received any update PRs for this action in https://github.com/gitflow-incremental-builder/gitflow-incremental-builder and I have enabled action updates via dependabot for quite some time now.

famod avatar Jan 17 '23 22:01 famod