obsidian-spaced-repetition icon indicating copy to clipboard operation
obsidian-spaced-repetition copied to clipboard

Published 20 hours ago • verified publisher icon st3v3nmw

Add card editing modal and edit later tagging

Open AB1908 opened this issue 2 years ago • 5 comments

To follow up on the general ideas of #414, #433, #269, #376, I went ahead and added two new features:

  • An edit later tag which has a default value of #edit-later. Can be toggled on as a setting.
  • A card editing modal, inspired by chhoumann/quickadd's wideInputPrompt class.

Both implementations are rather hacky IMO but I'm open to suggestions to clean it up.

AB1908 avatar Jun 20 '22 10:06 AB1908

Yikes, looks like I've botched the esbuild lol. I made the terrible mistake of making all my commits to the wrong branch and then having to rebase it on the latest upstream. Please let me know if I've broken anything.

AB1908 avatar Jun 20 '22 10:06 AB1908

I'd also like to split the "edit later" impl and the "edit in modal" implementation into two diff version based on commit for cleaner history purposes but not sure how to do that. Do I add tags to commits?

AB1908 avatar Jun 20 '22 10:06 AB1908

@FelixGibson, what have you added in your fork? I see you're 31 commits ahead and would like to collab on newer stuff.

AB1908 avatar Jun 21 '22 13:06 AB1908

@AB1908 happy to do that. I have added some interesting and might useful features in my fork. I'll try to pull request to the upstream these days.

FelixGibson avatar Jul 08 '22 12:07 FelixGibson

Sounds great! I go by the same handle on Obsidian's Discord in case you want to chat.

AB1908 avatar Jul 08 '22 21:07 AB1908

Hey @AB1908, please resolve the merge conflicts so that we push this. I'd love these changes to go in. Thanks!

st3v3nmw avatar Oct 12 '22 17:10 st3v3nmw

Will do! There were a few questions:

  • do you want to keep the open edit later in background option? I switched it to adding a tag.
  • my flashcard counts are wrong and I couldn't figure out how to update the deckTree correctly. I think I needed to delete the flashcard.

AB1908 avatar Oct 12 '22 19:10 AB1908

Thanks!

do you want to keep the open edit later in background option? I switched it to adding a tag.

A tag is better, I think.

  • my flashcard counts are wrong and I couldn't figure out how to update the deckTree correctly. I think I needed to delete the flashcard.

Lemme look into that bit of the code & see if I can figure out what's up

st3v3nmw avatar Oct 12 '22 19:10 st3v3nmw

I finally finished that today. I'll still need to pull down the changes and test locally.

AB1908 avatar Oct 26 '22 11:10 AB1908

Merged via https://github.com/st3v3nmw/obsidian-spaced-repetition/pull/587, thanks! Will be trying this out over the next few days.

st3v3nmw avatar Jan 08 '23 11:01 st3v3nmw

Err, I'm guessing it probably won't work and you should probably revert this haha. I'm redesigning my fork to support crud from the ground up.

AB1908 avatar Jan 08 '23 14:01 AB1908

Oops, just saw this. I tested it a little and it works fine, built a little on top of it too on https://github.com/st3v3nmw/obsidian-spaced-repetition/pull/589. Hopefully it won't be too difficult to redesign on top of the current master branch. Anyways, it's all good! 👍🏾

st3v3nmw avatar Jan 08 '23 14:01 st3v3nmw