zr-obp
zr-obp copied to clipboard
Wrong parameter set in fig.add_subplot() in OffPolicyEvaluation.visualize_off_policy_estimates_of_multiple_policies
Isn't the parameter for this part len(self.ope_estimators_)
instead of len(action_dist_list)
?
With the current code, I think that the output image will not be normal unless len(self.ope_estimators_)
and len(action_dist_list)
are the same number.
https://github.com/st-tech/zr-obp/blob/456a1ea652aafbabd73422413db0bbde4d8940aa/obp/ope/meta.py#L982
Perhaps there is a similar problem here.
https://github.com/st-tech/zr-obp/blob/456a1ea652aafbabd73422413db0bbde4d8940aa/obp/ope/meta_continuous.py#L658 https://github.com/st-tech/zr-obp/blob/456a1ea652aafbabd73422413db0bbde4d8940aa/obp/ope/meta_multi.py#L777
I think there is a bigger problem with this function.