ssv icon indicating copy to clipboard operation
ssv copied to clipboard

Load current instance when booting

Open amirylm opened this issue 3 years ago • 3 comments

Current instance state is saved into storage when it hits a prepare quorum. The idea is to save it in case the node crashes right after so when he boots again he can load the prepare state and continue from there.

amirylm avatar May 27 '21 15:05 amirylm

IMO we shouldn't load state. ibft should start from zero when boot in order to not miss some ibft decisions also, it can cause sync issues

@alonmuroch any thought? also what is the reason in the first place to save the state? except from metric (collector) there is no use of it

nivBlox avatar Aug 15 '21 11:08 nivBlox

The only thing I can think of is what happens if during an instance the node crashes. It won't start another instance for another epoch which will halt consensus.

alonmuroch avatar Aug 17 '21 13:08 alonmuroch

After discussions, decided to wait with that issue for future develop

nivBlox avatar Aug 17 '21 15:08 nivBlox