ssv icon indicating copy to clipboard operation
ssv copied to clipboard

network/discovery: rate limit skipped peers log

Open nkryuchkov opened this issue 1 year ago • 2 comments

@zktaiga reported that this log makes up to 40% of stage logs

nkryuchkov avatar Oct 18 '24 22:10 nkryuchkov

this looks good, but the map will never clean and may grow infinitely

instead of implementing cleanup, i suggest just using https://github.com/jellydator/ttlcache instead (because we already import it)

moshe-blox avatar Oct 21 '24 11:10 moshe-blox

@y0sher @moshe-blox I heard from @zktaiga we decided not to proceed with this solution, so can I close this?

nkryuchkov avatar Oct 26 '24 13:10 nkryuchkov

@y0sher @moshe-blox I heard from @zktaiga we decided not to proceed with this solution, so can I close this?

the solution we've merged was just a temporary one for the v2.0.0 release

moshe-blox avatar Nov 04 '24 15:11 moshe-blox

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.3%. Comparing base (e4a219a) to head (f8d3b63).

Files with missing lines Patch % Lines
network/discovery/dv5_service.go 40.0% 9 Missing :warning:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 31 '25 15:03 codecov[bot]