ssv icon indicating copy to clipboard operation
ssv copied to clipboard

Use unified block production from updated eth2 client

Open nkryuchkov opened this issue 11 months ago • 1 comments

Since https://github.com/attestantio/go-eth2-client/pull/116 GetBeaconBlock can return both proposal and blinded proposal.

This PR

  • removes the logic which eth2 client endpoint to choose
  • always uses GetBeaconBlock instead

TODO:

  • tests

nkryuchkov avatar Mar 21 '24 15:03 nkryuchkov

Codecov Report

Attention: Patch coverage is 21.73913% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 49.0%. Comparing base (86cddd7) to head (623609b).

Files Patch % Lines
beacon/goclient/proposer.go 0.0% 21 Missing :warning:
ekm/eth_key_manager_signer.go 17.6% 14 Missing :warning:
cli/operator/node.go 0.0% 1 Missing :warning:
Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 16:03 codecov[bot]

would rather we use official spec tag but I think its best we don't wait for it.

yeah we need to start testing this

moshe-blox avatar May 19 '24 15:05 moshe-blox