tinymembench icon indicating copy to clipboard operation
tinymembench copied to clipboard

arm: fix build on Thumb-only architectures

Open tpetazzoni opened this issue 9 years ago • 3 comments

Building tinymembench for ARM Cortex-M currently fails, because the arm-neon.S file contains ARM code that doesn't build on Thumb-only architectures. To account for this and fix the build for Cortex-M, this patch adjusts the compile time condition to also verify that the architecture supports the ARM instruction set, by testing the __ARM_ARCH_ISA_ARM compiler define.

Signed-off-by: Thomas Petazzoni [email protected]

tpetazzoni avatar Nov 11 '16 21:11 tpetazzoni

Thanks for the patch. What kind of Cortex-M system is that? I'm kinda surprised that tinymembench even works on such hardware, because of the use of mmap and relatively high memory allocation requirements (more than 64MiB). Do you have a tinymembench log from it? We have a lot of results from different systems reported in the wiki: https://github.com/ssvb/tinymembench/wiki

ssvb avatar Jan 29 '17 21:01 ssvb

I have tested it on actual hardware, this is merely a build fix.

tpetazzoni avatar Jan 30 '17 08:01 tpetazzoni

In my experience, untested fixes for compilation errors or warnings tend to do more harm than good. I guess it's up to me to check what can be done to add proper Cortex-M support. Thanks.

ssvb avatar Feb 06 '17 15:02 ssvb