draft-js-utils icon indicating copy to clipboard operation
draft-js-utils copied to clipboard

Allow multiple inlineStyles to be returned by customInlineFn

Open betancourtl opened this issue 6 years ago • 12 comments

What does this PR do?

Previously the customStyleFn only allowed you to apply a single style. This PR improves the behavior of the customInlineStyleFn by allowing it to return multiple inlineStyles so they can be applied to an an element.

Does it break anything?

This addition would enhance the functionality of the customStyleFn in a backwards compatible way.

Does it have tests?

Yes!

Who would benefit from this?

Here are several issues open that this functionality fixes.

  1. https://github.com/sstur/draft-js-utils/issues/142
  2. https://github.com/sstur/draft-js-utils/issues/154
  3. https://github.com/webdeveloperpr/draft-js-custom-styles/issues/2
  4. https://github.com/sstur/draft-js-utils/pull/136

I would love to have this merged. Please let me know your thoughts.

betancourtl avatar Dec 22 '18 05:12 betancourtl

it is a very useful feature. I look forward to the release

entryone avatar Mar 20 '19 18:03 entryone

When can we expect the release with this change?

tylde avatar May 31 '19 05:05 tylde

Whats the status on this?

mitchellwarr avatar Jul 17 '19 02:07 mitchellwarr

Any idea on if this will get merged? I would LOVE this functionality!

steveostudios avatar Aug 30 '19 20:08 steveostudios

When would you like to merge this PR, any idea? It would be really useful.

dobosmarton avatar Jan 29 '20 19:01 dobosmarton

It has been over a year since this PR was proposed, any word on why it hasn't been merged would be appreciated. Does it need more work? Are the maintainers just swamped? The bug this PR solves is a major painpoint, so a comment of any kind would be helpful

mitchellwarr avatar Jan 29 '20 19:01 mitchellwarr

Any updates on this?

iam-medvedev avatar Jul 06 '20 12:07 iam-medvedev

@webdeveloperpr Hello, did you found any substitution module that convert to HTML and convert from HTML ? Your fork was removed

msk-psp avatar Jul 29 '20 09:07 msk-psp

Are there any updates?

greenxiii avatar Nov 08 '20 23:11 greenxiii

waiting for update...

kimhou avatar Sep 30 '21 03:09 kimhou

@orenaksakal @entryone Any ideas on when this will get merged? It has been more than 3 years now.

timuster avatar Jan 09 '22 12:01 timuster

please merge this, just one line

khauthanhhieu avatar Mar 31 '22 09:03 khauthanhhieu