sst-elements icon indicating copy to clipboard operation
sst-elements copied to clipboard

Bad code in pymerlin-base

Open kvoronin-intel opened this issue 1 year ago • 2 comments

Hi!

This line https://github.com/sstsimulator/sst-elements/blob/master/src/sst/elements/merlin/pymerlin-base.py#L276 refers to undeclared "value" (copypasted piece of code from setattr?) which leads to Traceback (most recent call last): ... File "pymerlin-base.py", line 276, in getattr NameError: name 'value' is not defined. Did you mean: 'False'? FATAL: SSTPythonModel: Execution of model construction function failed.

Triggered by the following high-level print() attempt: networkif.input_buf_size = "32kB" networkif.output_buf_size = "32kB" -->print("networkif buf sizes = ", networkif.input_buf_size, networkif.output_buf_size)

I am not very familiar with internals of SST but this does look like a bug.

kvoronin-intel avatar Jun 06 '23 03:06 kvoronin-intel

Thanks. I'll take a look and put in a patch.

feldergast avatar Jun 21 '23 21:06 feldergast

@feldergast Did you patch this?

hughes-c avatar Aug 14 '23 12:08 hughes-c