sst-elements icon indicating copy to clipboard operation
sst-elements copied to clipboard

Ember: Possible error in Ember SpyPlot update method

Open saichennaintel opened this issue 2 years ago • 1 comments

I'm trying to understand the use of ember spyplot feature. Looking at the code, in essence, for each send operation, we are storing the three key details. a. Remote rank to which the current rank is sending the data b. No of times we send to this remote rank c. Total amount of data in bytes send to this remote rank.

However, in https://github.com/sstsimulator/sst-elements/blob/master/src/sst/elements/ember/libs/emberMpiLib.h#L164 , we see that the bytes being added for a send only considers the bytes of the corresponding datatype but not the count. Shouldn't the corresponding line be size_t bytes = count*api().sizeofDataType(dtype); instead of size_t bytes = api().sizeofDataType(dtype); ?

saichennaintel avatar Dec 21 '22 21:12 saichennaintel

I suspect you're correct. I'll take a look at it.

feldergast avatar Jan 03 '23 17:01 feldergast