sst-elements icon indicating copy to clipboard operation
sst-elements copied to clipboard

Vanadis::VanadisNodeOSCoreHandler::setBrk() has no return

Open pdbj opened this issue 2 years ago • 1 comments

New Issue for sst-element VANADIS

1 - Detailed description of problem or enhancement Vanadis::VanadisNodeOSCoreHandler::setBrk() is declared returning int but there is no return statement in the implementation

2 - Describe how to reproduce Compile sst-elements

Making all in vanadis
sst-elements/src/sst/elements/vanadis
  CXX      os/vnodeos.lo
In file included from ./os/vnodeos.h:25,
                 from os/vnodeos.cc:21:
./os/vnodeoshandler.h: In member function 'int SST::Vanadis::VanadisNodeOSCoreHandler::setBrk(uint64_t)':
./os/vnodeoshandler.h:105:5: warning: no return statement in function returning non-void [-Wreturn-type]
  105 |     }
      |     ^

Not clear whether the old or new value should be returned.

3 - What Operating system(s) and versions All

4 - What version of external libraries (Boost, MPI) NA

5 - Provide sha1 of all relevant sst repositories (sst-core, sst-elements, etc) sst/devel @ bcd759f8855943c2 sst-elements/devel @ https://github.com/sstsimulator/sst-elements/commit/19a6ad660b6d44dffc605f0981b33154ecbd7419

pdbj avatar Aug 05 '22 22:08 pdbj

Actually this appears to be called only in vanadis/os/vnodeos.cc:150, and the return value is ignored.

pdbj avatar Aug 05 '22 22:08 pdbj