sst-elements
sst-elements copied to clipboard
sstsimulator
Add io redirect functionality to Ariel
These changes add the ability to do IO redirection for the traced Ariel process.
The changes to the Ariel interface allow the user to specify files for stdin, stdout, and stderr. Additionally, they can specify whether they want to append or overwrite the files that used for stdout and stderr.
This is marked draft as I haven't written unit tests. I would appreciate any feedback.
Fixes #1856.
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.
The logic in the testsuite needs a bit of cleanup but this is nearly complete now.
Ready for review.
I added a new testsuite file instead of adding to the one there. I realize this has some amount of copy and pasted code, but the interface for creating tests needed to change quite a bit for these.
These tests should be orthogonal to any other Ariel tests. They only check that the traced program's stdout/stderr is in the right place (either in the sim output or in the specified redirect file) -- they do not check any of the simulation output.
The tests are not exhaustive, but each of the 8 tests takes about 7 seconds on the dev cluster and I didn't want to make things too slow.
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:
Pull Request Auto Testing STARTING (click to expand)
Build Information
Test Name: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements
- Build Num: 201
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements
- Build Num: 810
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist
- Build Num: 546
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2
- Build Num: 796
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2
- Build Num: 795
- Status: STARTED
Using Repos:
- Repo: ELEMENTS (hpcgarage/sst-elements)
- Branch: master
- SHA: 92b3706b622fbf3fa414566eb476bb7f00e2de1a
- Mode: TEST_REPO
- Repo: SQE (sstsimulator/sst-sqe)
- Branch: devel
- SHA: 6990def818b13838fca36bdd58f518d920cbf95d
- Mode: SUPPORT_REPO
- Repo: CORE (sstsimulator/sst-core)
- Branch: devel
- SHA: 5ce052c10b4f8e0f5d5cd7460236913eaac445d5
- Mode: SUPPORT_REPO
- Repo: MACRO (sstsimulator/sst-macro)
- Branch: devel
- SHA: f4fd93b133fd6eac8ab7a9b975159b7af38a84bb
- Mode: SUPPORT_REPO
Pull Request Author: plavin
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED
Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.
Pull Request Auto Testing has FAILED (click to expand)
Job: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements
- Result: FAILED
- Build #: 201
- URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements/201/consoleFull
- Job: - Status: FAILURE
Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements
- Result: FAILED
- Build #: 810
- URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements/810/consoleFull
- Job: - Status: FAILURE
Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist
- Result: FAILED
- Build #: 546
- URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist/546/consoleFull
- Job: - Status: FAILURE
Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2
- Result: FAILED
- Build #: 796
- URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2/796/consoleFull
- Job: - Status: FAILURE
Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2
- Result: FAILED
- Build #: 795
- URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2/795/consoleFull
- Job: - Status: FAILURE
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:
Pull Request Auto Testing STARTING (click to expand)
Build Information
Test Name: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements
- Build Num: 211
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements
- Build Num: 820
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist
- Build Num: 551
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2
- Build Num: 806
- Status: STARTED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2
- Build Num: 805
- Status: STARTED
Using Repos:
- Repo: ELEMENTS (hpcgarage/sst-elements)
- Branch: master
- SHA: 0a93a135084d6e68f069a91e0aebf12a6df6ece0
- Mode: TEST_REPO
- Repo: SQE (sstsimulator/sst-sqe)
- Branch: devel
- SHA: f31325785a3bacff2cc778a5b675ec3aac272597
- Mode: SUPPORT_REPO
- Repo: CORE (sstsimulator/sst-core)
- Branch: devel
- SHA: cc7808b2e4ecf869eb03af5d0ade77a8ee8b1052
- Mode: SUPPORT_REPO
- Repo: MACRO (sstsimulator/sst-macro)
- Branch: devel
- SHA: f4fd93b133fd6eac8ab7a9b975159b7af38a84bb
- Mode: SUPPORT_REPO
Pull Request Author: plavin
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED
Pull Request Auto Testing has PASSED (click to expand)
Build Information
Test Name: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements
- Build Num: 211
- Status: PASSED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements
- Build Num: 820
- Status: PASSED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist
- Build Num: 551
- Status: PASSED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2
- Build Num: 806
- Status: PASSED
Build Information
Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2
- Build Num: 805
- Status: PASSED
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ gvoskuilen ]!
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged
Merge on Pull Request# 1857: IS A SUCCESS - Pull Request successfully merged