sst-elements icon indicating copy to clipboard operation
sst-elements copied to clipboard

Missing return warnings for GCC for switch statements

Open jjwilke opened this issue 5 years ago • 6 comments

Several switch statements do not provide a trailing return or default case statement, leading GCC to spew complaints about missing return statements in memOp.h, nicEvents.h, and shmemapi.h

jjwilke avatar Apr 08 '19 19:04 jjwilke

@jjwilke Should this go into 9.1?

hughes-c avatar Jul 16 '19 07:07 hughes-c

@jjwilke @hughes-c Was this ever addressed? I will leave it open if so.

jwilso avatar Oct 21 '19 22:10 jwilso

@jwilso Not that I'm aware of.

hughes-c avatar Oct 22 '19 20:10 hughes-c

@allevin / @jjwilke - do we have a list of these we can knock out for the release?

nmhamster avatar Feb 19 '21 01:02 nmhamster

@jjwilke do you know what version of the gcc compiler was throwing the complaints?
I will try to do a warnings scrub next week.

allevin avatar Feb 19 '21 15:02 allevin

@jjwilke @nmhamster I cannot reproduce these build warnings. I tried GCC 4.8 and GCC 6.1... The issue was submitted in 2019, and may have been cleaned up since. I recommend closing.

allevin avatar Apr 07 '21 13:04 allevin