sst-elements icon indicating copy to clipboard operation
sst-elements copied to clipboard

Calculating regRegionDelay divides by magical 4096

Open deanchester opened this issue 6 years ago • 0 comments

I was taking a read through the firefly source to look further in to some of the configuration parameters and noticed that the regRegionDelay function checks to see if the length is larger than m_regRegionXoverLength and then divides by 4096 (which is the default for m_regRegionXoverLength ) should it be divided by m_regRegionXoverLength as this is customisable and not the magical 4096?

https://github.com/sstsimulator/sst-elements/blob/d08a39688fca004daa68ea0da7e841d73d652af8/src/sst/elements/firefly/ctrlMsgMemory.h#L102 https://github.com/sstsimulator/sst-elements/blob/d08a39688fca004daa68ea0da7e841d73d652af8/src/sst/elements/firefly/ctrlMsgMemory.h#L103 https://github.com/sstsimulator/sst-elements/blob/d08a39688fca004daa68ea0da7e841d73d652af8/src/sst/elements/firefly/ctrlMsgMemory.h#L104

deanchester avatar Aug 28 '18 10:08 deanchester