sst-core icon indicating copy to clipboard operation
sst-core copied to clipboard

Show SST internal configuration when verbose

Open pdbj opened this issue 2 years ago • 5 comments

It's often useful to document the internal SST configuration. This patch logs Config to the default simulator output, when verbose.

Patch Show SST configuration when verbose

pdbj avatar Apr 25 '22 22:04 pdbj

@feldergast, I can prep an issue-fix branch for a forthcoming PR if you approve.

jleidel avatar May 18 '22 20:05 jleidel

This isn't the way I would fix this issue. If there are multiple ways to print (Output object versus stdout, for example), I've been trying to consolidate things into a toString() function and then using that in the various print functions. Also, [[fallthrough]] is c++17, so isn't allowed in the core.

feldergast avatar May 18 '22 20:05 feldergast

Yes, I wasn't wild about the duplication. On the other hand my new function prints things with a little more formatting (column aligned), so some reconciling needs to occur.

pdbj avatar May 18 '22 20:05 pdbj

I have some changes to the config class on a branch I'm working on. I'll take the new code and tweak it into a toString() function. I'll use that in print() versions to take FILE* and Output. There's probably not a great reason to have a version that only goes to stdout.

feldergast avatar May 18 '22 21:05 feldergast