amqp-client icon indicating copy to clipboard operation
amqp-client copied to clipboard

Jar contains samples

Open thjaeckle opened this issue 8 years ago • 2 comments

I just noticed that the .jar amqp-client_2.11-1.5.jar contains a package "samples" with examples. This should not be included in the Jar - I would suggest moving that folder (either to "src/test" so that it is automatically compiled or to a top-level samples-folder).

thjaeckle avatar Jun 07 '16 13:06 thjaeckle

I've though about moving the samples to src/test before but never got around to actually doing it because I'm not sure that it is actually a problem. I've seen a few libraries that include sample so that users can run them to debug/diagnose problems easily and thought that it made sense. Why do you think it is a problem (honest question) ?

sstone avatar Jun 08 '16 16:06 sstone

You ain't gonna need them at runtime ever and users could mix the samples up with functionality of the library. The library isn't as lightweight as it could be (it already is very lightweigt :)). You also find the samples when for example doing a "look for code which uses this method/class/etc." and filter those out in order to find your code using the searched library function.

thjaeckle avatar Jun 08 '16 17:06 thjaeckle