stitch icon indicating copy to clipboard operation
stitch copied to clipboard

Serve from Windows with normal '/'s in your require paths

Open spiralman opened this issue 12 years ago • 8 comments

This not only fixes the raw '/' in getRelativePath, but also replaces the backslashes you get from Windows with forward slashes when generating the filename key for the compiled module function.

This lets you serve your files from Windows, but still use '/' in your require calls. Using '/' on the client side is nice because it's symmetrical with the server side (node accepts '/' in require on Windows) and lets you serve your files from Windows and Posix. Pus '/' is the One True Path Separator.

All tests pass (on Windows and Posix), but I cheated on "paths may be symlinks" since Windows doesn't really support symlinks.

Review on Reviewable

spiralman avatar Feb 24 '12 02:02 spiralman

+1 PULL THIS - Seriously this completely fixed my build issues in Windows

Hubro avatar Jul 19 '12 07:07 Hubro

+1

konstantinvlasenko avatar Dec 18 '12 01:12 konstantinvlasenko

+1

ngryman avatar Jan 30 '13 17:01 ngryman

+1 fixes windows

benjajaja avatar Jan 30 '13 18:01 benjajaja

+1 fixed my issue on windows

TheRightChoyce avatar Mar 10 '13 03:03 TheRightChoyce

+1

rbardini avatar May 11 '13 00:05 rbardini

Thank you! Fixed my issue.

cyrilis avatar May 30 '13 08:05 cyrilis

+1

kylekatarnls avatar Jun 12 '14 15:06 kylekatarnls