gzp
gzp copied to clipboard
Remove dependency on core_affinity crate
core_affinity is unmaintained (last update was 2 years ago, last real update was 4 years ago)
It links against System
on macos as a framework, which is marked as "do not use" in apple's documentation: https://github.com/NixOS/nixpkgs/pull/143861#issuecomment-955619290, and is causing darwin builds of crabz to fail in nixpkgs
Some possible alternatives I found: affinity
@figsoda thanks for making an issue! Great point, I will look to move away from core_affinity
ASAP / with the next release. I'm not sure when that's coming just yet, but it happen! PRs also welcome. core_affinity
is only used in two spots and should be straightforward to swap out.
looks like affinity
crate doesn't have get_core_ids
🤔
Closing along with https://github.com/sstadick/gzp/issues/37
Still could be nice to move off this, but I know have more of a relationship with the core_affinity author who did get things done when it needed to happen.
thanks for contacting! do you mind asking them to take a look at this? https://github.com/Elzair/core_affinity_rs/pull/17 I was just able to verify that the patch works as expected
I've asked 👍
thanks!
I believe it was resolved, I'll get another round our dependency updates in today at some point.