open-next icon indicating copy to clipboard operation
open-next copied to clipboard

feat(image-adapter): improve error handling and status codes

Open iDVB opened this issue 7 months ago • 6 comments

Moved to new PR against a non-main branch. Original PR here: https://github.com/opennextjs/opennextjs-aws/pull/886

Fixes #885

iDVB avatar Jun 06 '25 01:06 iDVB

🦋 Changeset detected

Latest commit: fdc1f4bcb527b6df304ddb8e824429d3f43beab8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Major
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 06 '25 01:06 changeset-bot[bot]

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@893

commit: fdc1f4b

pkg-pr-new[bot] avatar Jun 06 '25 13:06 pkg-pr-new[bot]

Just an update. This seems to be working the dream in our prod environment so far.

iDVB avatar Jun 12 '25 13:06 iDVB

Did this ever make it into the build? We see this build is broken now where it was working before... pnpm dlx https://pkg.pr.new/@opennextjs/aws@6f0044b build

There was a fix in the image server function that properly handled trailing querystring which now seem to be broken in this build now. (was working in this build less than a week ago)

# PROD: WORKS
/_next/image?w=384&q=75&url=https://images.ctfassets.net/s5qqrp96y1p4/7wHwJSvxFWpIYdm56bOdSk/1208a00c3e9ed4ad32102e84d494860c/IDX_Article_-_Cultural_Forces_5_IDX_HEADER__1_.png

# PROD: WORKS
/_next/image?w=384&q=75&url=https://images.ctfassets.net/s5qqrp96y1p4/7wHwJSvxFWpIYdm56bOdSk/1208a00c3e9ed4ad32102e84d494860c/IDX_Article_-_Cultural_Forces_5_IDX_HEADER__1_.png

---

# DEV: WORKS
/_next/image?w=384&q=75&url=https://images.ctfassets.net/s5qqrp96y1p4/7wHwJSvxFWpIYdm56bOdSk/1208a00c3e9ed4ad32102e84d494860c/IDX_Article_-_Cultural_Forces_5_IDX_HEADER__1_.png

# DEV: NOT WORK
/_next/image?w=384&q=75&url=https%3A%2F%2Fimages.ctfassets.net%2Fs5qqrp96y1p4%2F7wHwJSvxFWpIYdm56bOdSk%2F1208a00c3e9ed4ad32102e84d494860c%2FIDX_Article_-_Cultural_Forces_5_IDX_HEADER__1_.png

iDVB avatar Sep 08 '25 19:09 iDVB

@iDVB I rebased and pushed some changes that i requested. Could you test it please ?

conico974 avatar Sep 21 '25 13:09 conico974

@iDVB would you have time to test this?

vicb avatar Oct 08 '25 09:10 vicb