ion icon indicating copy to clipboard operation
ion copied to clipboard

fix: container environment variables

Open sellooh opened this issue 1 year ago • 1 comments

Container variables are being ignored and top level environment can't be set when using containers

Since this condition doesn't allow to specify top level environment variables, there is no workaround atm: https://github.com/sst/ion/blob/64a591a62287089adbf0f09636dd9f9112112814/platform/src/components/aws/service.ts#L232

This PR adds container env variables to the task definition

closes https://github.com/sst/ion/issues/1204

sellooh avatar Oct 02 '24 21:10 sellooh

Thanks

jayair avatar Oct 04 '24 19:10 jayair

What's holding this pr back? Would love to get that fix.

psteinroe avatar Oct 15 '24 10:10 psteinroe

Had conflicts with my PR and just fixed them - would also like to get this fixed, I'm using a patched version of the component for now but would love to just use SST's

sellooh avatar Oct 15 '24 13:10 sellooh

Releasing v3.2.30 with this fix - sorry about the delay

fwang avatar Oct 16 '24 16:10 fwang

thank you!

sellooh avatar Oct 16 '24 16:10 sellooh