Fixing gap at top of windows between top menu bar

[travisallison]

The changes are a hack, but they seem to do the job for the problem of a gap between the top menu bar and the window that is being tiled. Using gdk by itself doesn't do the job.

[ssokolow]

I definitely won't be merging this as-is because, as I mentioned, GDK has bugs that affect everyone, not just Unity users. However, I don't see a problem with taking it if you make it conditional on a config file boolean with a name like unity_hack and make the comment clarity correction I pointed out.

[landscape-bot]

Repository health decreased by 0.46% when pulling a0943ef on travisallison:fix_gap2 into 568dd1f on ssokolow:master.

• 2 new problems were found (including 0 errors and 0 code smells).
• No problems were fixed.

[mattgodbolt]

@travisallison if you could bring your branch up-to-date (and fix things like tabs->spaces) I'd love to use your branch for now to fix this issue locally. This has been bugging me for ages. Does this also fix the issue where the bottom of windows is off the bottom of the screen by ~4-8 pixels too?

[travisallison]

Sorry, I don't use quicktile anymore. My hack didn't work that well ultimately.

On Wed, Jun 15, 2016 at 9:39 AM, Matt Godbolt [email protected] wrote:

@travisallison https://github.com/travisallison if you could bring your branch up-to-date (and fix things like tabs->spaces) I'd love to use your branch for now to fix this issue locally. This has been bugging me for ages. Does this also fix the issue where the bottom of windows is off the bottom of the screen by ~4-8 pixels too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226245679, or mute the thread https://github.com/notifications/unsubscribe/AK1GPu7CKxenPTy0RxSikP_ltAFztmF2ks5qMCrKgaJpZM4Fd3Mc .

[mattgodbolt]

Thanks for the quick reply. Did you find an alternative or have you given up on tiling? On Wed, Jun 15, 2016 at 11:50 AM, travisallison [email protected] wrote:

Sorry, I don't use quicktile anymore. My hack didn't work that well ultimately.

On Wed, Jun 15, 2016 at 9:39 AM, Matt Godbolt [email protected] wrote:

@travisallison https://github.com/travisallison if you could bring your branch up-to-date (and fix things like tabs->spaces) I'd love to use your branch for now to fix this issue locally. This has been bugging me for ages. Does this also fix the issue where the bottom of windows is off the bottom of the screen by ~4-8 pixels too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226245679, or mute the thread < https://github.com/notifications/unsubscribe/AK1GPu7CKxenPTy0RxSikP_ltAFztmF2ks5qMCrKgaJpZM4Fd3Mc

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226248642, or mute the thread https://github.com/notifications/unsubscribe/AAmsddkXkCXnAaiu8gz4ME7u-SeRQAsWks5qMC1UgaJpZM4Fd3Mc .

[travisallison]

I just use the standard tiling the comes with ubuntu. I think it is Alt + number (from my laptop keypad). I switch between linux and windows and I am on windows right now so I am not 100% sure. If that doesn't work or you can't find it on your own, when I switch over to ubuntu, I'll send you another email. But it might be a few weeks since I don't need to program right now.

On Wed, Jun 15, 2016 at 1:34 PM, Matt Godbolt [email protected] wrote:

Thanks for the quick reply. Did you find an alternative or have you given up on tiling? On Wed, Jun 15, 2016 at 11:50 AM, travisallison [email protected] wrote:

Sorry, I don't use quicktile anymore. My hack didn't work that well ultimately.

On Wed, Jun 15, 2016 at 9:39 AM, Matt Godbolt [email protected] wrote:

@travisallison https://github.com/travisallison if you could bring your branch up-to-date (and fix things like tabs->spaces) I'd love to use your branch for now to fix this issue locally. This has been bugging me for ages. Does this also fix the issue where the bottom of windows is off the bottom of the screen by ~4-8 pixels too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/ssokolow/quicktile/pull/55#issuecomment-226245679 , or mute the thread <

https://github.com/notifications/unsubscribe/AK1GPu7CKxenPTy0RxSikP_ltAFztmF2ks5qMCrKgaJpZM4Fd3Mc

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226248642, or mute the thread < https://github.com/notifications/unsubscribe/AAmsddkXkCXnAaiu8gz4ME7u-SeRQAsWks5qMC1UgaJpZM4Fd3Mc

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226311505, or mute the thread https://github.com/notifications/unsubscribe/AK1GPvYfjeWAI22XjjeGOce7W3nCnL5jks5qMGHIgaJpZM4Fd3Mc .

[mattgodbolt]

Thanks again. I'm aware of the ctrl-keypad tiling built into (some) window managers: I like quicktile because I get to customize it more (and adds the ability to toggle a window's active monitor in a dual-monitor setup). It also (mostly) works across window managers; I just run quicktile.py and I magically get my setup regardless of the WM.

Thanks for the help!

On Wed, Jun 15, 2016 at 5:41 PM travisallison [email protected] wrote:

I just use the standard tiling the comes with ubuntu. I think it is Alt + number (from my laptop keypad). I switch between linux and windows and I am on windows right now so I am not 100% sure. If that doesn't work or you can't find it on your own, when I switch over to ubuntu, I'll send you another email. But it might be a few weeks since I don't need to program right now.

On Wed, Jun 15, 2016 at 1:34 PM, Matt Godbolt [email protected] wrote:

Thanks for the quick reply. Did you find an alternative or have you given up on tiling? On Wed, Jun 15, 2016 at 11:50 AM, travisallison < [email protected]> wrote:

Sorry, I don't use quicktile anymore. My hack didn't work that well ultimately.

On Wed, Jun 15, 2016 at 9:39 AM, Matt Godbolt < [email protected]> wrote:

@travisallison https://github.com/travisallison if you could bring your branch up-to-date (and fix things like tabs->spaces) I'd love to use your branch for now to fix this issue locally. This has been bugging me for ages. Does this also fix the issue where the bottom of windows is off the bottom of the screen by ~4-8 pixels too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/ssokolow/quicktile/pull/55#issuecomment-226245679 , or mute the thread <

https://github.com/notifications/unsubscribe/AK1GPu7CKxenPTy0RxSikP_ltAFztmF2ks5qMCrKgaJpZM4Fd3Mc

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/ssokolow/quicktile/pull/55#issuecomment-226248642 , or mute the thread <

https://github.com/notifications/unsubscribe/AAmsddkXkCXnAaiu8gz4ME7u-SeRQAsWks5qMC1UgaJpZM4Fd3Mc

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226311505, or mute the thread < https://github.com/notifications/unsubscribe/AK1GPvYfjeWAI22XjjeGOce7W3nCnL5jks5qMGHIgaJpZM4Fd3Mc

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ssokolow/quicktile/pull/55#issuecomment-226341389, or mute the thread https://github.com/notifications/unsubscribe/AAmsdQrf3QIWnRlrCyv5ZGgPenDDzi9gks5qMH-PgaJpZM4Fd3Mc .

[paulfeakins]

Any update on this one as I'm getting this same gap at the top on ubuntu 16.04 LTS?

[ssokolow]

Not yet. At the moment, I'm still on the tail end of getting everything ready for my copy of Firefox ESR to drop support for legacy extensions in a couple of days.

(And I've been scrambling a bit because the WebExtensions-based Tree Style Tab decided to get eager to corrupt the structure of my trees, so I suddenly had to rush to hack together a suitable stop-gap for preserving that information in usable fashion before I forgot what had been treed in which ways and why.)

I hope to start work on writing the test suite I need in maybe a week. QuickTile has built up too much technical debt, which has been compounded by a segfault bug in the official shim for porting PyGTK (GTK+ 2.x on Python 2) code to PyGI (GTK+ 2.x or 3.x on Python 2 or 3). I need a certain amount of automated regression testing in place before I can port to maintained versions of GDK and libwnck (which is probably enough to fix this bug) and start renovating out the architectural flaws that were present since the very first version of QuickTile.

Basically, I need to write some tests which spin up a virtual X11 desktop using something like Xvfb, start a window manager in it, create some mock windows, ask QuickTile to tile them, check whether the right result was achieved, and then clean up after themselves.

That'll also help with testing on desktops I don't use myself, because it'll be easy to do something like this:

SUPPORTED_WMS = ['openbox', 'kwin', ...]

for wm in SUPPORTED_WMS: 
    with test_desktop(wm) as test_env:
        run_tests(test_env)

[paulfeakins]

Makes sense, thanks for the update! I may just upgrade this 16.04 work computer to 18.04 as that seems to work nicely.

I've tried making a few quick changes to layout.py but I can't even seem to hack it to work with negative offsets.

[ssokolow]

After a lot of unexpected mess, I'm finally working to get things back in order. Is anyone still experiencing this problem?

If so, please point me to distro/DE combinations you're experiencing it under so I can fire them up in a VM for testing.