violet-paginator icon indicating copy to clipboard operation
violet-paginator copied to clipboard

state.get().add is not a function

Open liangklfangl opened this issue 7 years ago • 1 comments

If we install [email protected] and [email protected] manually, then next code fragment will throw:

function updatingItem(state, action) {
  return state.set('updating', state.get('updating').push(action.itemId));
}

But, if we downgrade to [email protected], everything works ok. This error appears using server-rending~

liangklfangl avatar May 23 '17 13:05 liangklfangl

Thanks for reporting this. Really not sure how I missed it.

This package is actually moving. Technically, it has already moved, but I have some actions left to take before I can deprecate this one. That includes adding better documentation for the new package.

I think the best solution for this repo is to update the peer dependencies in package.js to reflect the range of working versions. Then I can look into extending that range for the new package. It would be really great if you'd be willing to do two things:

  1. Submit a PR to update the peer dependencies
  2. Open this same issue in the new repo

sslotsky avatar Aug 03 '17 16:08 sslotsky