pornhub-api icon indicating copy to clipboard operation
pornhub-api copied to clipboard

demo code error (pip installing the wrong version)

Open AcGW-RErCotWd opened this issue 3 years ago • 10 comments

When initializing the client with search keywords, demo code says: keywords = ["word1", "word2"] client = pornhub.PornHub(keywords) But given the params of Pornhub is init(self, ProxyIP=None, ProxyPort=None, keywords=[], *args), the demo code actually assigns keywords to the ProxyIP, which took me some time to troubleshoot this minor error.

Correct demo code should be: keywords = ["word1", "word2"] client = pornhub.PornHub(keywords=keywords) , where the input is assign to the keywords param

AcGW-RErCotWd avatar Apr 27 '22 04:04 AcGW-RErCotWd

Hmm, as far as I remember, I changed it in pull request #13 I think I'm starting to figure out where these errors come from. Did you install the package via pip?

SashaSZ avatar Apr 27 '22 08:04 SashaSZ

Hmm, as far as I remember, I changed it in pull request #13 I think I'm starting to figure out where these errors come from. Did you install the package via pip?

Yeah, I did pip3 install pornhubapi

AcGW-RErCotWd avatar Apr 27 '22 18:04 AcGW-RErCotWd

Hmm, as far as I remember, I changed it in pull request #13 I think I'm starting to figure out where these errors come from. Did you install the package via pip?

Okay, I see what your saying, it seems like I have installed a different version (pornhubapi-0.1.0) of the module, but I am not sure why this is the case since I used pip

AcGW-RErCotWd avatar Apr 27 '22 18:04 AcGW-RErCotWd

I tried to install the package using pip + git, but it fails because there is no setup.py in the library

AcGW-RErCotWd avatar Apr 27 '22 18:04 AcGW-RErCotWd

It works when I re-install the package manually into the site-packages folder

AcGW-RErCotWd avatar Apr 27 '22 18:04 AcGW-RErCotWd

Hmm, as far as I remember, I changed it in pull request #13 I think I'm starting to figure out where these errors come from. Did you install the package via pip?

Okay, I see what your saying, it seems like I have installed a different version (pornhubapi-0.1.0) of the module, but I am not sure why this is the case since I used pip

pip is not updated to the current version, it remains only to wait for @sskender to do this, he is the owner of the repository. I here just send pull requests from time to time

SashaSZ avatar Apr 28 '22 05:04 SashaSZ

Hmm, as far as I remember, I changed it in pull request #13 I think I'm starting to figure out where these errors come from. Did you install the package via pip?

Okay, I see what your saying, it seems like I have installed a different version (pornhubapi-0.1.0) of the module, but I am not sure why this is the case since I used pip

pip is not updated to the current version, it remains only to wait for @sskender to do this, he is the owner of the repository. I here just send pull requests from time to time

Cool, np, I think this issue should be considered as solved, thx

AcGW-RErCotWd avatar Apr 28 '22 23:04 AcGW-RErCotWd

It is suggested that I leave this issue open until the installation from pip is correct

AcGW-RErCotWd avatar Apr 29 '22 05:04 AcGW-RErCotWd

At the moment pip version is maintained by @FormerlyChucks

If the issue stays unresolved I will create another pip package.

sskender avatar Apr 30 '22 21:04 sskender

Update:

There will be an official release soon, in the meantime please use the source code from GitHub and NOT pip library.

sskender avatar May 03 '22 16:05 sskender