ComfyUI_UltimateSDUpscale icon indicating copy to clipboard operation
ComfyUI_UltimateSDUpscale copied to clipboard

Feature request: support custom sampler

Open frankyifei opened this issue 1 year ago • 3 comments

New sampler and schedulers emerging quickly, is it possible to make ultimateSDUpscale support these new techniques, such as TCD sampler, AlignYourSteps schedulers, restart scheduler and others.

frankyifei avatar May 08 '24 12:05 frankyifei

So you want a node input for custom sampler nodes?

ssitu avatar May 08 '24 15:05 ssitu

yes, it would be great if it can use custom sampler. I understand it is current using common_sampler, is it going to be lots of work supporting this?

frankyifei avatar May 09 '24 04:05 frankyifei

Probably not, I'll see what I can do

ssitu avatar May 09 '24 14:05 ssitu

Probably not, I'll see what I can do

hey, if possible could you do the same for the scheduler (sigmas ?) AlignYourSteps isn't usable atm with ultimate upscale. This scheduler would be super useful with it.

ethanfel avatar May 30 '24 14:05 ethanfel

So just add inputs for a custom sampler and custom sigmas? And which approach is more preferable: adding them as optional inputs vs making new nodes for them?

ssitu avatar May 30 '24 14:05 ssitu

So just add inputs for a custom sampler and custom sigmas? And which approach is more preferable: adding them as optional inputs vs making new nodes for them?

I believe both ways work. I would probably choose a new node myself. Following Comfyui arrangement with the regular ksampler without the inputs and the 2 samplercustoms with inputs.

ethanfel avatar Jun 01 '24 08:06 ethanfel

ive been yearning for this feature since custom schedulers became a thing. i would love a "sigmas" input.

tilktilk5 avatar Jun 10 '24 02:06 tilktilk5

Oh yeah I was just looking to see if I could use AYS scheduler with this, so yes please!

gobshyte avatar Jun 26 '24 00:06 gobshyte

Alright, a new node has been added for this. Let me know if there are any issues/suggestions with the new one or any bugs that may have appeared with the old nodes.

ssitu avatar Jun 26 '24 02:06 ssitu

Excellent, but... can I use this new node in place of SD Upscale (No Upscale) ? At the moment I am testing with an upscaler connected but with upscale set to 1.0 instead, and hoping that mimics the behaviour of the No Upscale node but alowing custom sampler/sigmas

gobshyte avatar Jun 26 '24 20:06 gobshyte

I think I'll make the upscale model optional, so it will skip the upscale if it's not provided.

ssitu avatar Jun 26 '24 21:06 ssitu

I think I'll make the upscale model optional, so it will skip the upscale if it's not provided.

thanks for the update, it's great

ethanfel avatar Jun 27 '24 17:06 ethanfel