Simeon Simeonov

JSON-RPC 2.0 non-compliant behavior

1

The spec mandates that responses must include either `result` or `error` but not both. The code in https://github.com/movitto/rjr/blob/master/lib/rjr/messages/response.rb#L62 does not reflect this. As a result, for example, RJR talking to...

Exposes blocking() via server constructor

2

Per the README, blocking() should be exposed by the server constructor function and not the instance objects. This makes sense for two reasons: 1. Developers should be able to define...

Pluggable message encoding?

7

It's great that the module offers pluggable transports. Any thoughts on breaking serialization/deserialization out of the transport so that, for example, collaborating clients & servers that support more efficient encodings...

Schema discovery created unpersistable schema for empty arrays

4

If all observed values of a document field are `[]` the generated schema is for `ArrayType[NullType]` which cannot be persisted or used in any meaningful way. In the absence of...

Connections leaking and actively sending commands on 0.12.0

1

Despite the multiple improvements to prevent connection leakage, I have observed a sharp spike in leaked connections moving to 0.12.0 from 0.11.2 (the migration is required by our move to...