Add device_model_id and software_version_id properties

[ssilverman]

Also capitalize "Manufacturer" in the manufacturer_id description for consistency.

Fixes #13

[ssilverman]

@mayanigrosh @sammysmallman Have a look at this and check for correctness and consistency?

[mayanigrosh]

@mayanigrosh @sammysmallman Have a look at this and check for correctness and consistency?

I'd like to argue that the two new keys be required.

[ssilverman]

@mayanigrosh @sammysmallman Have a look at this and check for correctness and consistency?

I'd like to argue that the two new keys be required.

Are you also saying that you’d like for manufacturer_id to be required? The three values form a tuple.

[ssilverman]

I'm still not sure I agree with this change. See my comment here: https://github.com/ssilverman/rdm-schema/issues/13#issuecomment-1132144970 Also see this comment: https://github.com/ssilverman/rdm-schema/issues/13#issuecomment-1132153042

In short, the data isn't necessary because each message doesn't need to be self-contained.

[mayanigrosh]

@mayanigrosh @sammysmallman Have a look at this and check for correctness and consistency?

I'd like to argue that the two new keys be required.

Are you also saying that you’d like for manufacturer_id to be required? The three values form a tuple.

manufacturer_id is already required I'm suggesting that device_model_id and software_version_id also be required. I'd prefer if they were separate keys and not grouped into an object like in Sammy's original suggestion.