Shawn Silverman
Shawn Silverman
Discovered with -Wextra (-Wcast-function-type) and setting USB_MIDI_SERIAL.
Disovered with -Wextra (-Wsign-compare). I'll leave the SMalloc ones alone for now, to make it easier to do any updates in the future.
Because this keyboard defines KEYCODE_EXTRA00, usb_keyboard.c's unicode_to_keycode() can return a 16-bit quantity. See: https://forum.pjrc.com/threads/71926-Button-Press-detector?p=319143&viewfull=1#post319143
https://github.com/PaulStoffregen/cores/blob/06492c1d11b93879b74d8db586d4acce5f2ea5ea/teensy4/IntervalTimer.cpp#L108 It looks like if the function is `nullptr` then the interrupt won't get cleared. Should the interrupt be cleared anyway?
Many of the `FileImpl` and `File` functions return `size_t`, however it's very common for the underlying filesystem implementation to return a negative value as an error code. A great example...
Received 7-bit serial data on Teensy 4 sometimes has the top bit set. A PR is forthcoming...
I was reading this: https://forum.pjrc.com/threads/69288-Strange-IRQ_CMP0-behaviour-of-Teensy-3-2-help-needed-to-track-down-issue?p=298177&viewfull=1#post298177 and remembered I've seen `asm("dsb")` instructions without the `volatile`. The following places in this repo use this instruction without `volatile`: 1. https://github.com/PaulStoffregen/cores/blob/fdfd18f935fac6859d19154e4c11f869e685b7d4/teensy4/usb_serial.c#L343 2. https://github.com/PaulStoffregen/cores/blob/fdfd18f935fac6859d19154e4c11f869e685b7d4/teensy4/usb_serial.c#L388 3....
Builtin has exactly the same speed. This is from #616. I volunteered to take over the commit. One thing that was't clear from the conversation is should the grouping be...
This adds a 'runningFlags' variable to IntervalTimer and addresses the TODO. This adds tracking of which PIT timer is running so that the PIT IRQ can be disabled appropriately. (Note...