Shawn Silverman
Shawn Silverman
See: https://forum.pjrc.com/threads/71505-7-bit-support-seems-to-be-missing-on-Teensy-4 That top bit, because it's the last in the stream, turns out to be the value of the parity bit. On to a fix...
Okay, I think I got it. There has to be an appropriate mask depending on the mode. I tested this with a 7E1 device, both directions.
I updated the PR to include a commit for fixing teensy3 7-bit support. Tested with the same 7E1 device.
Here's my logic for fixing this: All formats other than 7-bit don't set the parity bit when a user reads bytes. It is unexpected for the 7-bit format to set...
The same program works fine with the _QNEthernet_ library. Here's the code with some very minor (indicated) modifications: ```c++ // --- NativeEthernet --- // #include //
Note: I didn't modify the Teensy 2 code. I'm hesitant because I'm not certain how much change should be introduced there.
I changed my mind and changed the Teensy 2 code. Let me know if this is a desirable thing.
I just force pushed changing the `KEYCODE_MASK` to `0x07ff`. Still figuring out if that's correct.
This also addresses some of #660.
I just read this thread in the forum: https://forum.pjrc.com/threads/71929-Timer-mystery I figure now is a good time to ping on this PR.