Stephen Sigwart

Results 56 comments of Stephen Sigwart

It looks like something happened to `smarty.net`, so that's why the tests are failing: ![image](https://github.com/smarty-php/smarty/assets/1426848/bf6bedca-7c26-4089-baf9-fa3f025fa7f5)

> My fear is that non local scopes might be an issue 😆 > > Will have to spend more time on it. Yep. I'll spend more time on testing...

@wisskid, I added more tests for each scope. I think they are all working, so I think this is ready for review.

> But to be honest, right now I still doubt if we really need this. I was worried about that. That's why I asked before spending the time to update...

I probably could do that. Since this PR seems to be fully working with scopes too, I'd probably include all the new code. However, I probably won't do this. It...

@wisskid, you are referring this a part of the following statement from https://www.smarty.net/docs/en/api.append.by.ref.tpl: ![image](https://github.com/smarty-php/smarty/assets/1426848/0c225e61-4517-4f4d-9aeb-d7b1b8736e18) Honestly, I've never paid attention to that or probably even seen it since we started on...

I rebased this so that the unit tests pass now that the Smarty website dependency is fixed.

I just submitted #17364 which solves this. However, if there are both staged and unstaged changes to a renamed file, I couldn't figure out how to show both of them,...

@sergiou87, I see that `app/src/lib/status-parser.ts` sets `workingTree` to `GitStatusEntry.Modified `: https://github.com/desktop/desktop/blob/a1ece186bae3a742f206c5edeb0762e78fba2f7c/app/src/lib/status-parser.ts#L322-L329 If I could find a way to pass through that field to the diff renderer, I could have it...

Thanks, @sergiou87. I opened #17467. It's still a bit of passing around fields, but doesn't mess with the actual `git diff` command, so hopefully this PR is better.