Samuel Sieb

Results 378 comments of Samuel Sieb

> src/esphome/components/ethernet/ethernet_component.cpp:8:10: fatal error: eth_phv/phy_lan8720.h: No such file or directory Did you copy and paste that or retype it? `eth_phv` is wrong, it should be `eth_phy`. But the files I...

Looks like https://github.com/esphome/issues/issues/3400 is a problem for regular ESP32 as well.

https://github.com/esphome/esphome/pull/3667 will fix the test4 failure.

You are correct, not sure what happened there. Test1 is the adc, test2 and test4 are Ethernet.

This won't be accepted like that. You can't override the framework, especially when it's specific to a transport. You can keep this as an external component. Also, sending the "off"...

> I was asking for what the syntax for the static array would be on one of @ssieb comments Just put `static` in front of it and move it to...

As I mentioned in https://github.com/esphome/esphome/pull/3515, this will break the use of many IR database entries.

What "toggle logic" are you referring to? How is this different than using the timed cover with built-in endstops?

I don't understand how that is useful for your case. I kind of understand the point of this PR, but I think the better option would be to add toggle...

The template cover has support for the opening and closing status.