SSH.NET icon indicating copy to clipboard operation
SSH.NET copied to clipboard

Fix netconf framing protocol

Open schaveyt opened this issue 2 years ago • 1 comments

Problem

The implementation was not compliant to the RFC6242. Although the client does NOT support the framing protocol, if the server reported that is did, the client would still try to using the framing protocol. The result is that client and server are unable to communicate at the RPC XML layer and the session times out.

Solution

The solution is to simply never used framing protocol regardless of whether the server does or not.

Additional Minor Changes

  1. Address null pointer exception when the netconf_session is disposing.
  2. Add an example of the RPC XML to use when transmitting calls.

Experimental Release for .NET Standard 2.1

https://github.com/schaveyt/SSH.NET/releases/tag/2021.04.02

schaveyt avatar Apr 03 '22 03:04 schaveyt

I think we should take this one on good faith. I have no knowledge of netconf and we have no testing but it seems reasonable to me, and with #639 and #1197 there are at least 3 people for whom it works.

Rob-Hague avatar Dec 08 '23 09:12 Rob-Hague

It appears that at least for Cisco WLCs, the implementation of the framing protocol is indeed broken. I need to hardcode _usingFramingProtocol = false; to get SendReceiveRpc to do anything but timeout.

@WojciechNagorski Please merge this PR.

ddombrowsky avatar Jun 13 '24 16:06 ddombrowsky

I took #639 and the remaining comments from this one

Rob-Hague avatar Jun 16 '24 09:06 Rob-Hague